Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Build Library For Distribution (swift compatibility) #51

Closed
cgmaier opened this issue Nov 1, 2019 · 8 comments
Closed

Build Library For Distribution (swift compatibility) #51

cgmaier opened this issue Nov 1, 2019 · 8 comments

Comments

@cgmaier
Copy link
Contributor

cgmaier commented Nov 1, 2019

hi! wondering if you'd be able to set the Build Libraries For Distribution flag to YES in the project's build settings. i use deep diff through Carthage and this would help to ensure support for new swift versions which seem to come with every new xcode release.

thank you !

@github-actions
Copy link

github-actions bot commented Nov 1, 2019

Message that will be displayed on users' first issue

@cgmaier
Copy link
Contributor Author

cgmaier commented Nov 6, 2019

hey @onmyway133 any update on this ? it's quite an easy but important improvement which will really help myself and future devs ! I'm hoping not to have to fork.

@onmyway133
Copy link
Owner

@cgmaier ja, thanks for the suggestion. If you can make a PR for it ?

@cgmaier
Copy link
Contributor Author

cgmaier commented Nov 6, 2019

@onmyway133 done!

@cgmaier
Copy link
Contributor Author

cgmaier commented Nov 8, 2019

hey @onmyway133 let me know what ya think : )

@cgmaier
Copy link
Contributor Author

cgmaier commented Nov 11, 2019

thanks for merging the PR @onmyway133 ! a new release with this change would be great :)

@onmyway133
Copy link
Owner

@cgmaier Hi, sorry for delay. I just made https://github.com/onmyway133/DeepDiff/releases/tag/2.3.1, and thanks for using DeepDiff, I love Giphy too

@cgmaier
Copy link
Contributor Author

cgmaier commented Nov 14, 2019

you're my hero!! thank u @onmyway133

@cgmaier cgmaier closed this as completed Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants