Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃[QUESTBOARD-FEATURE] Implement standard user-options for renderer (toggle coronas, etc) #7

Open
onnoj opened this issue Apr 13, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@onnoj
Copy link
Owner

onnoj commented Apr 13, 2024

Normally, the renderer plugins in Deus Ex implement a number of default options.
For example, with the default software renderer, you can set the following options in the deusex.ini file:

  • Translucency=True
  • VolumetricLighting=True
  • ShinySurfaces=False
  • Coronas=False
  • HighDetailActors=True
  • HighResTextureSmooth=True
  • LowResTextureSmooth=False
  • FastTranslucency=True

Currently, this renderer does not implement any user-options at all.
It would be good if there was at least an option to toggle the coronas.

Options specific to this renderer could be:

  • If the thread affinity hack should be enabled
  • If unlit textures should be rendered as emissive.
  • Anything for future features, like self-shadowing.
  • Maybe flashlight settings

Ideally, this would be implemented as a class that abstracts the reads from GConfig, is accessible as a singleton, and offers getters/setters for the properties (perhaps to initialize defaults). The goal is to make sure all properties are funnelled through this configuration manager, so that all definitions are together and documented.

@onnoj onnoj added enhancement New feature or request good first issue Good for newcomers labels Apr 13, 2024
@onnoj
Copy link
Owner Author

onnoj commented Apr 13, 2024

For reference, you can check the other existing renderers, or if SoftDrv.cpp (the default software renderer).
Basically, it involves calls to GConfig->GetSectionPrivate and GConfig->GetInt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 馃 Open Quests
Development

No branches or pull requests

1 participant