Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shufflenet has an old version of BatchNormalization op (that uses consumed_inputs) #35

Closed
spandantiwari opened this issue Apr 12, 2018 · 8 comments
Assignees

Comments

@spandantiwari
Copy link

The Shufflenet model in this repo has an older version of BatchNormalization op in the model, that uses the attribute consumed_inputs. There are two issues with this:

  1. This version is quite old and several frameworks that support ONNX do not have support for it.
  2. Furthermore, the older version's spec does not have a good description for this attribute.

Is it possible to remove this attribute from the model and generate the model with the latest version of the BatchNormzalization op?

@spandantiwari
Copy link
Author

@houseroad - I was expecting to see other models also to not have "consumed_inputs" attribute for BatchNormalization based on this post (#13), but I am seeing it in others as well, such as Resnet50. Could this just be an issue of the links pointing to the older models?

@houseroad
Copy link
Member

@spandantiwari
Copy link
Author

Yes, this model is fine.

@prasanthpul
Copy link
Member

@houseroad @jspisak can you update the READMEs of all the models to list the right links? This is impacting many users. Using the new README template would be ideal

@houseroad houseroad self-assigned this Apr 18, 2018
@houseroad
Copy link
Member

@prasanthpul thanks for reminding this. I will update it soon.

@spandantiwari
Copy link
Author

@houseroad - thanks for that. I am also wondering if we can have links to the older (opset < 6) models as well somewhere just because we have the models anyway?

@houseroad
Copy link
Member

@spandantiwari Yes, I have listed two major versions, opset_3 (stable version with release 1.1.0) and opset_6 (master branch)

@spandantiwari
Copy link
Author

Awesome! Thanks @houseroad .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants