Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider leveraging lintrunner for the linting needs #5

Open
thuang6 opened this issue May 9, 2024 · 0 comments · May be fixed by #16
Open

Consider leveraging lintrunner for the linting needs #5

thuang6 opened this issue May 9, 2024 · 0 comments · May be fixed by #16

Comments

@thuang6
Copy link
Contributor

thuang6 commented May 9, 2024

please consider lintrunner since it is a standard check in the ONNX repository. It will provide a uniform linting experience in CI and in local environments, even though there is no auto-fix-in-CI features yet (can be implemented if needed). In practice, the local autofix experience has been good. refer to:

https://github.com/onnx/onnx/blob/main/CONTRIBUTING.md#coding-style
https://github.com/onnx/onnx/blob/main/.lintrunner.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant