Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The rank for "iou_threshold" and "score_threshold" of NonMaxSuppression is unclear #2212

Closed
winnietsang opened this issue Jul 31, 2019 · 2 comments
Assignees
Labels
bug operator Issues related to ONNX operators stale

Comments

@winnietsang
Copy link

In https://github.com/onnx/onnx/blob/master/docs/Operators.md#nonmaxsuppression, it state that both "iou_threshold" and "score_threshold" are scalar but in the unit tests all of the values for "iou_threshold" and "score_threshold" are 1D tensor. I also look at https://github.com/onnx/onnx/blob/master/onnx/defs/object_detection/defs.cc, I can't tell what is the expected rank for both "iou_threshold" and "score_threshold". May someone please clarify what is the expected rank for these two inputs.

@askhade
Copy link
Contributor

askhade commented Jul 31, 2019

The spec says it is a Scalar so it should be treated as a scalar. I will update the tests and shape inference for this op to reflect the same.

@askhade askhade self-assigned this Jul 31, 2019
@askhade askhade added the bug label Jul 31, 2019
@prasanthpul prasanthpul added the operator Issues related to ONNX operators label Aug 16, 2019
@stale
Copy link

stale bot commented Mar 28, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Mar 28, 2022
@stale stale bot closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug operator Issues related to ONNX operators stale
Projects
None yet
Development

No branches or pull requests

3 participants