Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NonMaxSuppression spatial_dimension should be num_boxes? #2360

Closed
Timmmm opened this issue Sep 26, 2019 · 1 comment
Closed

NonMaxSuppression spatial_dimension should be num_boxes? #2360

Timmmm opened this issue Sep 26, 2019 · 1 comment
Labels
operator Issues related to ONNX operators stale

Comments

@Timmmm
Copy link

Timmmm commented Sep 26, 2019

It says

boxes : tensor(float)
An input tensor with shape [num_batches, spatial_dimension, 4].

And an example is:

boxes = np.array([[[0.0, 0.0, 1.0, 1.0],
                   [0.0, 0.1, 1.0, 1.1],
                   [0.0, -0.1, 1.0, 0.9],
                   [0.0, 10.0, 1.0, 11.0],
                   [0.0, 10.1, 1.0, 11.1],
                   [0.0, 100.0, 1.0, 101.0]],
                  [[0.0, 0.0, 1.0, 1.0],
                   [0.0, 0.1, 1.0, 1.1],
                   [0.0, -0.1, 1.0, 0.9],
                   [0.0, 10.0, 1.0, 11.0],
                   [0.0, 10.1, 1.0, 11.1],
                   [0.0, 100.0, 1.0, 101.0]]]).astype(np.float32)

So spatial_dimension is 6? It's pretty clear to me that the spatial dimension is hardcoded to 2 (i.e. boxes are 2D), and spatial_dimension should be renamed num_boxes. Perhaps the original intention was to allow 1D, 2D, and 3D boxes with dimensions [num_batches, num_boxes, spatial_dimension, 2]?

@prasanthpul prasanthpul added the operator Issues related to ONNX operators label Sep 30, 2019
@stale
Copy link

stale bot commented Mar 28, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Mar 28, 2022
@stale stale bot closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator Issues related to ONNX operators stale
Projects
None yet
Development

No branches or pull requests

2 participants