-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification about TensorProto.segment #2630
Comments
Thank you! @edgchen1 Yep. this looks confusing... @postrational any comments on this? I'd suggest to deprecate one mechanism of storing large tensors if possible. |
The external data field was designed to work around limitations of protobuf file size limits. I haven't yet seen a model using |
This is the Rust debug println of this test proto: https://github.com/onnx/onnx/blob/master/onnx/backend/test/data/node/test_identity_sequence/test_data_set_0/input_0.pb
Could someone comment on what the |
FWIW, I think this is still an unanswered question. The comments haven't been clarified yet: Lines 517 to 524 in a252e65
|
TensorProto has a segment member.
From here:
What do begin and end mean? How are large tensors supposed to be represented with multiple TensorProtos?
External data is another way to handle large tensors. Does that mechanism supersede this, or is there still a use for segment?
On a related note, I also had some TensorProto questions here: #2392. Any clarification there would be appreciated as well.
The text was updated successfully, but these errors were encountered: