Enable no-untyped-def in mypy

[justinchuby]

Use no-untyped-def to encourage typing annotations.

[daspartho]

Hi @justinchuby ,
I'd like to contribute to this issue, so could you please explain what the issue is about and point me to some resources to get started before I begin?

[avisinghal6]

@jcwchen , I would like to work on this enhancement, could you kindly guide me through it .

[jcwchen]

@jcwchen , I would like to work on this enhancement, could you kindly guide me through it .

Thank you for your interest! Please add no-untyped-def=true in this file:

onnx/pyproject.toml

Line 1 in 2c5da6f

[tool.mypy]

and run mypy onnx (use the latest mypy from PyPI); Fix every error related to no-untyped-def. After that, submit a PR to see whether all relevant errors have been resolved in the Lint CI.

[avisinghal6]

#self-assign

[avisinghal6]

I will create the PR by tomorrow morning.

[avisinghal6]

Created PR #5272

[avisinghal6]

@jcwchen I created the PR and "enforce styles" is failing, i checked the error, the errors are because there are a lot of functions which dont specify a type definition. The solution it shows is to add "# type: ignore[no-untyped-def]" at top of each of the files. Since there are so many files, i was wondering if this is the way to proceed or there is an efficient method. Kindly advise.

[jcwchen]

I am not aware any efficient method to apply it and thus you might need to add the type annotation one by one. Adding annotations is preferred than adding ignore at the top unless there is a strong reason not to have types. There are quite many errors around no-untyped-def and it needs huge effort to apply it entirely... This work can be broken down into several PRs if needed. Thanks!