Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add affine_grid op #5225

Merged
merged 39 commits into from Jul 31, 2023
Merged

add affine_grid op #5225

merged 39 commits into from Jul 31, 2023

Conversation

liqunfu
Copy link
Contributor

@liqunfu liqunfu commented May 13, 2023 •
edited

Description

Motivation and Context

#4983

@liqunfu
initial change
c54ccf4 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu requested a review from a team as a code owner May 13, 2023 05:24
@liqunfu liqunfu marked this pull request as draft May 13, 2023 05:24
@liqunfu
passed 2d non-align_corners function body in parser test
6de815c 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
passed 2/3-d align or not corvers with parser test
275293d 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
update def FunctionBody and test models
6a02339 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu changed the title (WIP) add afine_grid op (WIP) add affine_grid op May 14, 2023
xadupre
xadupre reviewed May 17, 2023
View reviewed changes
onnx/test/parser_test.py Outdated Show resolved Hide resolved
@liqunfu
shape inference (incomplete), reference implementation, and more tests
13ff153 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu changed the title (WIP) add affine_grid op add affine_grid op May 22, 2023
@liqunfu
all tests passed, fixed most comments
3cec59d 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
replace mul of ones with add of zeros
cfdd63c 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
merge
ba3d48f 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems May 23, 2023
View reviewed changes
onnx/reference/ops/_op_list.py Fixed Show resolved Hide resolved
onnx/test/parser_test.py Fixed Show fixed Hide fixed
@liqunfu
lint and undo parser test
eed4463 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu marked this pull request as ready for review May 23, 2023 00:26
@liqunfu liqunfu requested a review from a team as a code owner May 23, 2023 00:26
@liqunfu
size to be int64 only - shape dtype
eee0c33 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
skip affine_grid test_backend_onnxruntime.py
86233f7 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
skip test comment
945b5be 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
lint
f195e19 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
lint
82329ed 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
merge main
5bd2de8 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
lint
090ae54 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 10, 2023
View reviewed changes
onnx/test/reference_evaluator_backend_test.py Dismissed Show dismissed Hide dismissed
onnx/test/reference_evaluator_backend_test.py Dismissed Show dismissed Hide dismissed
onnx/test/test_backend_onnxruntime.py Dismissed Show dismissed Hide dismissed
@liqunfu
lint
76b0aad 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
crlf to lf
05e6ae5 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
Merge branch 'main' into liqun/affine_grid
ac4627e
@liqunfu
TestCoverage.md
a5b9d23 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
symbolic tests
ba2f2e3 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
Merge branch 'main' into liqun/affine_grid
31d670e
@liqunfu
docs/TestCoverage.md
63baf6d 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
reviewers' comments
07e48cc 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
Merge branch 'main' into liqun/affine_grid
29e72ac
@liqunfu
remove unneeded test cases that use ref evaluator
c9b9cc8 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
lint
57c49e8 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
add comment for assert
bc12bd6 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu
Merge branch 'main' into liqun/affine_grid
45ac099
@liqunfu
lint
f47cdcd 
Signed-off-by: Liqun Fu <liqfu@microsoft.com>
@liqunfu liqunfu added this pull request to the merge queue Jul 31, 2023
Merged via the queue into main with commit a1b9354 Jul 31, 2023
34 checks passed
@liqunfu liqunfu deleted the liqun/affine_grid branch July 31, 2023 21:32
@liqunfu liqunfu mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinchuby justinchuby justinchuby left review comments

@xadupre xadupre xadupre left review comments

@gramalingam gramalingam gramalingam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liqunfu @gramalingam @justinchuby @xadupre