Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans for Supporting Torch #7

Closed
sbodenstein opened this issue Sep 8, 2017 · 7 comments
Closed

Plans for Supporting Torch #7

sbodenstein opened this issue Sep 8, 2017 · 7 comments

Comments

@sbodenstein
Copy link

sbodenstein commented Sep 8, 2017

@soumith: I know that there are plans for supporting PyTorch. Are there any plans for supporting Torch? Or will it be supported indirectly via a Torch to PyTorch converter?

@soumith
Copy link

soumith commented Sep 8, 2017

we have no plans of supporting lua torch, and are unlikely to look into it.

@sbodenstein
Copy link
Author

Ok, thanks for the rapid response!

@ezyang
Copy link
Contributor

ezyang commented Sep 8, 2017

However, we are planning to support importing onnx models into PyTorch. The priority for this particular feature is not high, but we may need it for some high priority work that is going on.

@jsenellart
Copy link
Contributor

jsenellart commented Apr 26, 2018

Hello, I am willing to work on converting lua-torch models to ONNX - at least in the context of the OpenNMT project for which it should be pretty straightforward. @soumith - is there some entry point on how to write a converter to ONNX?

@linkerzhang
Copy link
Member

There're several xxx -> onnx converters in our repo, which you may want to refer to please. https://github.com/onnx/onnxmltools covers converting core-ml/scikit-learn models to onnx.
https://github.com/onnx/tensorflow-onnx covers converting tf models to onnx.

Of course, they're not having 100% coverage.

@jsenellart
Copy link
Contributor

thanks - I will give a try.

@jsenellart
Copy link
Contributor

Hello, I have a first draft of luatorch > onnx extraction here: https://github.com/jsenellart/luatorch-onnx-convert. Still work in progress, but it works end-to-end and converts discovered nn, nngraph and onmt modules to onnx - infering shapes when necessary, and building initializers. Contact me if you need specific support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants