Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CTCBeamSearchDecoder #2302

Open
CaptainDario opened this issue Feb 10, 2024 · 2 comments
Open

Support CTCBeamSearchDecoder #2302

CaptainDario opened this issue Feb 10, 2024 · 2 comments
Labels
pending on user response Waiting for more information or validation from user unsupported ops Issues related to unsupported operators

Comments

@CaptainDario
Copy link

New Operator

Describe the operator

Basic BeamSearch decoder as described here

Do you know this operator be constructed using existing ONNX operators?

I think so but I am not sure

Is this operator used by any model currently? Which one?

Many models use beam search for decoding the bare output such as CRNN.

Are you willing to contribute it? (Y/N)

N

Notes

I am trying to convert a CRNN model from TensorFlow that uses beam search.
I am fairly new to ONNX and I am getting this error when trying to convert it.

Tensorflow op [crnn/CTCBeamSearchDecoder: CTCBeamSearchDecoder] is not supported
Unsupported ops: Counter({'CTCBeamSearchDecoder': 1})

When looking at the operator kernel list beam search is listed, therefore I assumed it would be supported.
Am I doing something wrong?

@CaptainDario CaptainDario added the unsupported ops Issues related to unsupported operators label Feb 10, 2024
@fatcat-z
Copy link
Collaborator

Yes, it is highly possible that BeamSearch op in ORT could be mapped to CTCBeamSearchDecoder op directly.

To make the conversion happen, we need to add a mapping and set the attributes/inputs accordingly. One example is TensorScatterAdd op and adding relative tests.

And if possible, your contributions are definitely welcome!

@fatcat-z fatcat-z added the pending on user response Waiting for more information or validation from user label Mar 10, 2024
@CaptainDario
Copy link
Author

Thank you for your response!
I am interested in this but need to put down my research for the next months.
If nobody adds this maybe I will work on it in a few months but currently I am unsure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending on user response Waiting for more information or validation from user unsupported ops Issues related to unsupported operators
Projects
None yet
Development

No branches or pull requests

2 participants