Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rendering a list of conceptschemes #101

Closed
koenedaele opened this issue Oct 5, 2023 · 0 comments
Closed

Update rendering a list of conceptschemes #101

koenedaele opened this issue Oct 5, 2023 · 0 comments
Labels
backend enhancement to estimate

Comments

@koenedaele
Copy link
Member

Part of OnroerendErfgoed/atramhasis#850

Todo:

  • Get the URI from provider.get_vocabulary_uri as opposed to provider.concept_scheme.uri
  • Handle ProviderUnavailable exceptions due to fetching the label or find another way to have the list work when an external provider is down (AAT being the most common culprit)
@koenedaele koenedaele changed the title Updaten rendering a list of conceptschemes Update rendering a list of conceptschemes Oct 19, 2023
koenedaele added a commit that referenced this issue Oct 19, 2023
@koenedaele
Better error handling of conceptschemes that fail to load. Refs #101
062b2f6
Wim-De-Clercq added a commit that referenced this issue Oct 20, 2023
@Wim-De-Clercq
Add test, fix error message, avoid getting label twice.
99f1fa7 
#101
Wim-De-Clercq added a commit that referenced this issue Oct 20, 2023
@Wim-De-Clercq
When there is no exception but no label, fallback to vocabulary uri.
ef20286 
#101
koenedaele added a commit that referenced this issue Oct 20, 2023
@koenedaele @Wim-De-Clercq
Better error handling of conceptschemes that fail to load. Refs #101 (#…
41ab58d 
…103)

* Better error handling of conceptschemes that fail to load. Refs #101

* Add test, fix error message, avoid getting label twice.

#101

* When there is no exception but no label, fallback to vocabulary uri.

#101

---------

Co-authored-by: Wim De Clercq <declewi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend enhancement to estimate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@koenedaele