Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ons-splitter-mask Not Being Registered #3059

Closed
ashuey opened this issue May 9, 2023 · 3 comments
Closed

Ons-splitter-mask Not Being Registered #3059

ashuey opened this issue May 9, 2023 · 3 comments
Assignees
Labels

Comments

@ashuey
Copy link

ashuey commented May 9, 2023

Environment

Onsen UI Version:

  • 2.12.8

Framework:

  • React 18.2.0

Framework binding:

  • react-onsenui 1.13.2

Platform:

  • MacOS 13.3.1 Chrome
  • Built with Vite 4.3.5

Encountered problem
When creating a page with a Splitter element, the ons-splitter-mask element is created, but the element is not registered as a custom element, causing event listeners not to be attached.

How to reproduce
Using: https://onsen.io/playground/?framework=react&category=reference&module=splitter
The code on playground does not have this issue, as it uses browser imports. This issue can be replicated by copying the code into a new React project with Vite and compiling in dev or prod mode.

It appears that dist/react-onsenui.js in the react-onsenui package is missing an import of onsenui/esm/elements/ons-splitter-mask.js

Manually importing this file in a project fixes the issue as a workaround: import 'onsenui/esm/elements/ons-splitter-mask';

yong-asial added a commit that referenced this issue Jun 20, 2023
#3059: add SplitterMask for onsenui-react
@yong-asial
Copy link
Member

@ashuey we have added (registered) ons-spitter-mask and released it in react-onsenui 1.13.3. Please have a test and let us know whether it resolve the problem.

Additionally, we would like to know how do you use splitterMask in your project? Thank you.

PR: #3063

@github-actions
Copy link

This issue is stale because it has been open for 60 days with no activity. If there is no activity in the next 7 days, the issue will be closed.

@github-actions github-actions bot added the stale label Sep 19, 2023
@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale. Please open a new issue if you believe you are encountering a related problem.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants