Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if_platform.js doesn't detect BlackBerry Playbook, BlackBerry 10 #45

Closed
jamespatrickwhite opened this issue Feb 25, 2014 · 2 comments
Closed

if_platform.js doesn't detect BlackBerry Playbook, BlackBerry 10 #45

jamespatrickwhite opened this issue Feb 25, 2014 · 2 comments

Comments

@jamespatrickwhite
Copy link

framework/directives/if_platform.js : Line 49 needs two additional regex tests:

from:
if (navigator.userAgent.match(/BlackBerry/i)) {

to:
if ((navigator.userAgent.match(/BlackBerry/i)) || (navigator.userAgent.match(/RIM Tablet OS/)) || (navigator.userAgent.match(/BB10/i))) {
@kruyvanna
Copy link
Contributor

@dzeims : Great!! 👍 Could you make a pull request? We'd like to add you as contributor.

@kruyvanna
Copy link
Contributor

pull request merged

@lock lock bot added the outdated label May 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kruyvanna @jamespatrickwhite