Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gexec: some impatient unit tests fail even on not-sluggish systems #580

Closed
thediveo opened this issue Aug 29, 2022 · 1 comment
Closed

Comments

@thediveo
Copy link
Collaborator

While an Intel Haswell Core i7 isn't exactly the newest kid on the block(chain), it isn't a slug either. On an Ubuntu 22.04.1LTS two gexec unit tests fail reproducibly: both start one or more sleeps and then send it/them SIGABRT. None of them manages to keep the tight 1s default limit. Raising these allowed deadline to safe 3s (or maybe 5s) allow them to pass every time. As it seems, SIGABRT-based tests need more headroom on systems for which core dumps are getting written (even with a snappy SSD).

The affected tests are session_test.go lines 127 and 241.

Wanna PR?

@onsi
Copy link
Owner

onsi commented Aug 29, 2022

😂 yes please and thank you

@thediveo thediveo changed the title gexec: some inpatient unit tests fail even on not-sluggish systems gexec: some impatient unit tests fail even on not-sluggish systems Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants