session.mediaHandler.on('getDescription', ...) doesn't apply to early dialogs

[josephfrazier]

Here's a demo. Comment out the inviteWithoutSdp: true line to see it working as expected.

This is because each early dialog uses its own MediaHandler (see #7), but it's still counter-intuitive.

EDIT: This applies to the 'setDescription' event as well, of course

[josephfrazier]

Here's one potential workaround:

session.mediaHandler.on('getDescription', handleGet);
session.mediaHandler.on('setDescription', handleSet);

// Early dialogs have their own media handlers, so listen for their events too.
// See https://github.com/onsip/SIP.js/issues/275
session.on('dialog', function (dialog) {
  dialog.mediaHandler.on('getDescription', handleGet);
  dialog.mediaHandler.on('setDescription', handleSet);
});

[josephfrazier]

So, one way to fix this would be to add the above workaround into sip.js (with analogous behavior for event handler removal, of course). This would mean that 'getDescription' and 'setDescription' can be emitted multiple times during session establishment, but that seems to be more in line with the purpose and documentation of the events in the first place. This would also reduce the need for adding Dialog to the publicly documented API (see onsip/sipjs.com#23 (comment)).

Thoughts?

[egreenmachine]

We believe that this issue may be resolved in the latest tagged version 0.8.0. Can you please retest with that version and let us know if this is still an issue. We will close this issue on 11/1/17 if we do not hear back. Thanks.

[egreenmachine]

As stated in previous post, closing due to inactivity and proposed solution in 0.8.X. If this turns out to still be an issue, please re-open.