Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session's dtmf event is incorrectly documented #9

Closed
Rob--W opened this issue Jul 18, 2014 · 1 comment
Closed

Session's dtmf event is incorrectly documented #9

Rob--W opened this issue Jul 18, 2014 · 1 comment

Comments

@Rob--W
Copy link

Rob--W commented Jul 18, 2014

http://sipjs.com/api/0.6.0/session/#dtmf

.on('dtmf', function(dtmf, request) {})

Source code:

Session/DTMF.js:  this.owner.emit('dtmf', this.request, this);
Session/DTMF.js:    this.owner.emit('dtmf', request, this);

I think that the code is correct and the documentation is wrong, because putting the request/response first seems to be the convention in your library.

@josephfrazier josephfrazier self-assigned this Jul 18, 2014
@josephfrazier
Copy link
Contributor

Good call! As you can see, we haven't quite gotten all of the documentation updated with the changes between 0.5.0 and 0.6.0 yet. Let us know if you spot any more inconsistencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants