Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] OMT Basemap generates transportation_name entry for minor roads #144

Closed
boldtrn opened this issue Mar 23, 2022 · 6 comments
Closed
Labels
bug Something isn't working

Comments

@boldtrn
Copy link
Contributor

boldtrn commented Mar 23, 2022

Describe the bug

Planetiler creates a transportation_name entry with a ref for minor roads. This differs to OMT. I have a style that shows road signs. It now shows road signs for hiking and cycling routes.

To Reproduce
Steps to reproduce the behavior:

  1. Compare OMT tiles to Planetiler OMT.

For example:
https://www.openstreetmap.org/relation/2268453
https://www.openstreetmap.org/relation/1153402

Expected behavior

I don't think it's an issue that Planetiler does this. There are applications that want to show highway signs for cycle routes etc. At least I think we should document it. That way, I know what I am getting and can update my styles to consider this change.

Screenshots

OMT vs Planetiler:
Screenshot 2022-03-23 at 08 45 57
Screenshot 2022-03-23 at 08 46 13

@wipfli
Copy link
Contributor

wipfli commented Mar 23, 2022

Interesting, is it maybe that transportation_name should only create a feature if name is present?

@boldtrn
Copy link
Contributor Author

boldtrn commented Mar 23, 2022

I am actually not 100% sure what the base logic in OMT is to create the ref. I assume it has to be a road of tertiary or higher. If there is a ref attached to a road, showing a road sign is good, even though the road has no name.

Just to make sure: I think it's not an issue that Planetiler behaves like this, as I could imagine scenarios where people need this info. It slightly breaks OMT compatibility.

@wipfli
Copy link
Contributor

wipfli commented Mar 23, 2022

@ZeLonewolf?

@msbarry
Copy link
Contributor

msbarry commented Mar 25, 2022

I think I see the issue, it should only use ref tags from major networks, not minor ones. Put out a fix for this and #145 in #148

@msbarry
Copy link
Contributor

msbarry commented Mar 25, 2022

In #148 I'm making the default behavior match openmaptiles, but you can opt-into the old behavior with the --transportation-name-minor-refs flag.

@msbarry
Copy link
Contributor

msbarry commented Mar 25, 2022

Fixed in #148

@msbarry msbarry closed this as completed Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants