Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the semantic type expansion #13

Open
jonquet opened this issue Nov 17, 2016 · 8 comments
Open

Implement the semantic type expansion #13

jonquet opened this issue Nov 17, 2016 · 8 comments

Comments

@jonquet
Copy link

jonquet commented Nov 17, 2016

When using the Annotator and filtering the result by smeantic types, the hiearchy of the semantic network must be used to include all the sub classes (transitive) of the selected semantic types.

For instance, if I select T057
http://bioportal.lirmm.fr/ontologies/STY/?p=classes&conceptid=http%3A%2F%2Fpurl.lirmm.fr%2Fontology%2FSTY%2FT058

then it is equivalent to select:T058, T060, T061, T059

This must be implemented in the Java proxy (i.e. this project) by automatically expanding the parameter
&semantic_types=T058
to
&semantic_types=T058,T060,T061,T059

@jonquet
Copy link
Author

jonquet commented Nov 17, 2016

Once implemented (@twktheainur looks into this), assign to @vemonet to add the following sentence:
"Selected semantic types are non exclusives (like a OR) and expanded to include their sub types as described by the hierarchy of the UMLS Semantic Network (http://bioportal.lirmm.fr/ontologies/STY)"

@jonquet
Copy link
Author

jonquet commented Nov 18, 2016

After checking with @mdorf from NCBO this is actually partially implemented with the &expand_semantic_types_hierarchy=true option.

For instance:
http://services.bioportal.lirmm.fr/annotator/?text=yeux&ontologies=MSHFRE&longest_only=false&exclude_numbers=false&whole_word_only=true&exclude_synonyms=false&semantic_types=T021&expand_mappings=false&apikey=c34b7653-0639-4946-81af-8ac76fe809dd&&expand_semantic_types_hierarchy=true

returns D005123 that has semantic type 023

@jonquet
Copy link
Author

jonquet commented Nov 18, 2016

However, there the current implementation is not transitive... i.e., all the childrena are not inclulded.

For instances:
http://services.bioportal.lirmm.fr/annotator/?text=yeux&ontologies=MSHFRE&longest_only=false&exclude_numbers=false&whole_word_only=true&exclude_synonyms=false&semantic_types=T017&expand_mappings=false&apikey=c34b7653-0639-4946-81af-8ac76fe809dd&&expand_semantic_types_hierarchy=true

Does not return anything where as it should...as the hierarchy is
T017
-----T021
---------T023

Will create an issue on NCBO tracker for this.

@jonquet
Copy link
Author

jonquet commented Nov 18, 2016

@jonquet
Copy link
Author

jonquet commented Jan 25, 2017

@mdorf Any news on this ?

@mdorf
Copy link

mdorf commented Jan 25, 2017

I haven't worked on this yet. The priority at this point is a) Re-designed BP Homepage, b) AllegroGraph, c) CEDAR Enhancements. NCBO-1838 is marked as "Low" priority. Let me know if this needs to be elevated (I'll need to coordinate with John).

@syphax-bouazzouni
Copy link
Contributor

is it done @jonquet ?

@jonquet
Copy link
Author

jonquet commented Apr 4, 2024

We can address this with @Bilelkihal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants