Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommonJS support #16

Closed
namuol opened this issue May 26, 2015 · 6 comments
Closed

CommonJS support #16

namuol opened this issue May 26, 2015 · 6 comments
Labels
feature request v2

Comments

@namuol
Copy link

namuol commented May 26, 2015

Since the package is on NPM, it would be nice if module.exports were utilized if available -- currently require('geolocator') returns undefined.
@am-karl
Copy link

am-karl commented Jun 3, 2015

+1 for this

@lostpebble
Copy link

Yes please. This is default expected behaviour for packages on NPM.

@onury
Copy link
Owner

onury commented Jun 23, 2015

Thanks. Ok.
This will be implemented in the next release.

@tcastelli
Copy link

+1

1 similar comment
@khmelevskii
Copy link

+1

@lostpebble lostpebble mentioned this issue Mar 2, 2016
Closed
@onury onury added the v2 label Apr 4, 2016
@onury
Copy link
Owner

onury commented Jun 27, 2016

This is implemented in v2 (released).
Thanks.

@onury onury closed this as completed Jun 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request v2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@namuol @khmelevskii @lostpebble @tcastelli @onury @am-karl