Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] - Light YouTube Embedded #112

Closed
3 tasks done
rwstorer opened this issue Jun 9, 2023 · 3 comments · Fixed by #114
Closed
3 tasks done

[FEATURE] - Light YouTube Embedded #112

rwstorer opened this issue Jun 9, 2023 · 3 comments · Fixed by #114
Labels
enhancement New feature or request

Comments

@rwstorer
Copy link
Contributor

rwstorer commented Jun 9, 2023

I have checked all the prerequisites below and I don't see this is available

  • Read the README.md
  • Have the extended version of Hugo installed
  • Used the exampleSite's config.toml as a reference

Lite YouTube Embedded
https://github.com/paulirish/lite-youtube-embed

I added the JS and the CSS to my head.html partial, and it loads the YouTube embed much faster.

I only implemented a very minimal part of this script.

I created a shortcode "liteyoutube.html" with this code in it:

The markdown script just had this in it:
{{< liteyoutube videoid="your_vid_id" >}}

Just a thought.

@rwstorer rwstorer added the enhancement New feature or request label Jun 9, 2023
@onweru
Copy link
Owner

onweru commented Jun 9, 2023

Hi @rwstorer, if you can help with a PR, I would happily accept it.

@rwstorer
Copy link
Contributor Author

rwstorer commented Jun 9, 2023

I will learn how to do a PR. I'll get back to you.
You can see how it behaves on my site here Bucket Gardening

@rwstorer
Copy link
Contributor Author

I think I figured out how to do the PR. I'm working on integrating the feature into my fork of your repo. Once I do, I'll submit the PR.

@rwstorer rwstorer mentioned this issue Jun 11, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants