Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onyx pkg does not handle well dependent package nodes configured as git URLs in KDL #92

Closed
hatappo opened this issue Jan 4, 2024 · 1 comment

Comments

@hatappo
Copy link
Contributor

hatappo commented Jan 4, 2024

Observations

https://github.com/hatappo/pkg-example-onyx is my example onyx package repository.

onyx pkg add https://github.com/hatappo/pkg-example-onyx.git produces below in onyx-pkg.kdl:

// ...
dependencies {
    https://github.com/hatappo/pkg-example-onyx.git "0.3.0" git="https://github.com/hatappo/pkg-example-onyx.git" 
}

Then onyx pkg sync modify above into:

dependencies {
    https: "0.0.0" 
}

Successful Cases

onyx pkg command with package name of "github.com/onyx-lang/pkg-{}" type has no problem, such as onyx pkg add http-server && onyx pkg sync

Cause

I Think there may be some improvements to the KDL parser.

Other References

@brendanfh
Copy link
Collaborator

Your fix has been merged in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants