Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Raccoon Can Search for, but not Download Certain Apps #44

Closed
bcas9472 opened this issue Oct 2, 2017 · 4 comments
Closed

Fix for Raccoon Can Search for, but not Download Certain Apps #44

bcas9472 opened this issue Oct 2, 2017 · 4 comments

Comments

@bcas9472
Copy link

bcas9472 commented Oct 2, 2017

I am not sure if this is the right fix, or if Patrick will decide to do something different, but the problem of not being able to download certain apps from Play Store using Raccoon dates back for me all the way to 4.0 when I started using it. I've been able to reproduce and fix the problem on my Raccoon with no other impact.

https://youtu.be/mN5naAPk-GE

java -cp raccoon.jar org.hsqldb.util.DatabaseManagerSwing --url jdbc:hsqldb:file:raccoondb_4

ALTER TABLE PUBLIC.PERMISSIONS ALTER COLUMN NAME VARCHAR(1000)
ALTER TABLE PUBLIC.ANDROIDAPPS ALTER COLUMN NAME VARCHAR(1000)

This 100% fixed my downloading/importing problem. I batch imported over 200 apk's without issue or a hicup.

Example app of causing issue: Samsung Browser Beta (com.sec.android.app.sbrowser.beta)

Couldn't download or Import before the fix.

DESCRIBE_TABLES_AFTER.txt

[DESCRIBE_TABLES_BEFORE.txt]
(https://github.com/onyxbits/raccoon4/files/1348473/DESCRIBE_TABLES_BEFORE.txt)

DESCRIBE_TABLES_sqlext.txt

raccoondb_4_BEFORE.scriptext.txt

raccoondb_4_AFTER.scriptext.txt

@bcas9472
Copy link
Author

bcas9472 commented Oct 2, 2017

Sorry I dont know how to fork and fix and all that - not a developer.

@onyxbits
Copy link
Owner

onyxbits commented Oct 2, 2017

It kinda is the right thing to do (#42). Some app makers appearently use permissions in a creative way.
1000 is not a good number though. The 255 character limit was justified by assuming that no one would use longer permissions and then the string length could be stored in a single byte. Since we obviously need two bytes, we might as well bump the limit to 32k (gotta read up on that, though. Not sure how hsqldb handles it).

@bcas9472
Copy link
Author

bcas9472 commented Oct 2, 2017

Thanks for taking the time to read it, I appreciate the app you work on I use it everyday. Like I said, Im not a developer but it sure was fund involving myself in trying to fix it so I can use it more.
If you need me to test anything let me know.

@onyxbits
Copy link
Owner

onyxbits commented Oct 9, 2017

Fixed

@onyxbits onyxbits closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants