Better detection of remote images

Weeds out bad paths/URLs like //directory/image.jpg
modxcms · Aug 28, 2013 · b6f847d · b6f847d
1 parent e2f8dc6
commit b6f847d
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/components/phpthumbof/model/phpthumbof.class.php b/core/components/phpthumbof/model/phpthumbof.class.php
@@ -92,8 +92,8 @@ public function debugmsg($msg, $phpthumbDebug = FALSE) {
  *  Returns the filename of the cached image on success or $src on failure
  */
 public function createThumbnail($src, $options) {
-	if ( preg_match('/^(?:https?:)?\/\/(.+?)\/(.+)/i', $src, $matches) ) {  // if we've got a remote image to work with
-		$file = $this->config['cachePath'] . preg_replace("/[^\w\d\-_\.]/", '-', "{$matches[1]}-{$matches[2]}");  // generate a cache filename
+	if ( preg_match('/^(?:https?:)?\/\/((?:.+?)\.(?:.+?))\/(.+)/i', $src, $matches) ) {  // if we've got a remote image to work with
+		$file = $this->config['cachePath'] . preg_replace('/[^\w\d\-_\.]/', '-', "{$matches[1]}-{$matches[2]}");  // generate a cache filename
 		if (!file_exists($file)) {  // if it's not in our cache, go get it
 			$fh = fopen($file, 'wb');
 			if (!$fh) {