Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: properly resume players even on full restart #53

Merged
merged 5 commits into from
Feb 17, 2023
Merged

feat!: properly resume players even on full restart #53

merged 5 commits into from
Feb 17, 2023

Conversation

ooliver1
Copy link
Owner

Summary

  • Players is now a list property, not a dictionary attribute.
  • Handle all errors and print them from reconnecting on disconnect.
  • Fetch all players and form their data on reconnect.

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

@ooliver1 ooliver1 added t: enhancement Type: enhancement - new feature or request p: medium Priority: medium - should be worked on in the near future labels Feb 17, 2023
@ooliver1 ooliver1 enabled auto-merge (squash) February 17, 2023 20:21
@ooliver1 ooliver1 merged commit e3d7ba5 into master Feb 17, 2023
@ooliver1 ooliver1 deleted the feat/proper-resuming branch February 17, 2023 20:26
@ooliver1 ooliver1 mentioned this pull request Feb 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: medium Priority: medium - should be worked on in the near future t: enhancement Type: enhancement - new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ooliver1