Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add documentation for contributing #6

Merged
merged 7 commits into from
Oct 28, 2022
Merged

docs: add documentation for contributing #6

merged 7 commits into from
Oct 28, 2022

Conversation

ooliver1
Copy link
Owner

Summary

  • CONTRIBUTING.md for contributing guidelines and help
  • ISSUE_TEMPLATE for issue forms
  • move slotscheck to pre-commit

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

@ooliver1 ooliver1 added t: docs Type: docs - improvements or additions to documentation t: meta Type: meta - this does not relate to code or documentation labels Oct 28, 2022
spifory
spifory suggested changes Oct 28, 2022
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
ooliver1 and others added 2 commits October 28, 2022 17:13
@ooliver1
docs(contributing): apply code review suggestions
39f64e8 
Co-authored-by: Sham <thesham@protonmail.com>
@ooliver1
Update CONTRIBUTING.md
1f2094b 
Co-authored-by: Sham <thesham@protonmail.com>
@ooliver1 ooliver1 requested a review from spifory October 28, 2022 16:13
spifory
spifory approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@spifory spifory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ooliver1 ooliver1 merged commit 81fde97 into master Oct 28, 2022
@ooliver1 ooliver1 mentioned this pull request Oct 28, 2022
Merged
@ooliver1 ooliver1 deleted the ooliver1/docs/contributor-help branch January 18, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spifory spifory spifory approved these changes

Assignees
No one assigned
Labels
t: docs Type: docs - improvements or additions to documentation t: meta Type: meta - this does not relate to code or documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ooliver1 @spifory