Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): urlencode query #66

Merged
merged 1 commit into from
Apr 30, 2023
Merged

fix(node): urlencode query #66

merged 1 commit into from
Apr 30, 2023

Conversation

ooliver1
Copy link
Owner

Summary

URL encode identifier when querying a track. This fixes an issue where
track names with spaces would not be found.

Checklist

  • If code changes were made then they have been tested.
  • I have run task lint to format code and my changes.
  • I have run task pyright and fixed the relevant issues.

@ooliver1 ooliver1 added t: bug Type: bug - something isn't working p: high Priority: high - should be worked on as soon as reasonable labels Apr 30, 2023
@ooliver1 ooliver1 enabled auto-merge (squash) April 30, 2023 15:13
@ooliver1 ooliver1 merged commit f31ff5e into master Apr 30, 2023
6 checks passed
@ooliver1 ooliver1 deleted the fix/urlencode-query branch April 30, 2023 15:14
@ooliver1 ooliver1 mentioned this pull request Apr 30, 2023
Merged
ooliver1 added a commit that referenced this pull request Apr 30, 2023
@ooliver1
revert: "fix(node): urlencode query (#66)"
2308d15 
This reverts commit f31ff5e.
@ooliver1 ooliver1 mentioned this pull request Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
p: high Priority: high - should be worked on as soon as reasonable t: bug Type: bug - something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ooliver1