feat: transfer players to new nodes #85
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is impressive that it even works.
NodePool.remove_node
has been added, which has atransfer_players
keyword argument, which:False
: destroys all playersTrue
:Player.transfer_to
with the best node per playerPlayer.transfer_to
tries its best to:Node.close
was also added to disconnect and cleanup an old node, called inNodePool.remove_node
Checklist
task lint
to format code and my changes.task pyright
and fixed the relevant issues.