Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement probe orchestration #14

Closed
3 of 6 tasks
bassosimone opened this issue Jun 5, 2019 · 3 comments
Closed
3 of 6 tasks

Implement probe orchestration #14

bassosimone opened this issue Jun 5, 2019 · 3 comments
Assignees
Labels
effort/L Large effort enhancement New feature or request ooni/probe-engine Issues related to github.com/ooni/probe-engine priority/low Low priority

Comments

@bassosimone
Copy link
Member

bassosimone commented Jun 5, 2019

We need to have a complete implementation of probe orchestration in here. For now, we just have support for getting the test lists. Here's what remains to be done:

  • implement the register API
  • implement the login API
  • implement the update API
  • implement the task related APIs
  • implement the API expected by mobile apps (see mkall-ios, android-libs)
  • remove the orchestra implementation from MK

Note that we can safely remove the orchestra implementation from MK because it is marked as an internal API. Therefore, we can do that without violating any API constraint.

@bassosimone bassosimone added the enhancement New feature or request label Jun 5, 2019
@bassosimone bassosimone added this to Backlog in DO NOT USE (was: OONI Nettests and Engine) via automation Jun 5, 2019
@bassosimone bassosimone self-assigned this Jun 18, 2019
@bassosimone bassosimone changed the title story: implement probe orchestration Implement probe orchestration Aug 28, 2019
@bassosimone bassosimone added the P2 label Sep 10, 2019
@bassosimone bassosimone removed their assignment Sep 12, 2019
@hellais hellais added this to Icebox in OONI-Verse Oct 8, 2019
@bassosimone
Copy link
Member Author

I have implemented the APIs we currently use on mobile, plus the APIs required by psiphon as part of making psiphon available to probe-engine (see #89). Since there are no plans ahead to implement the rest of probe-orchestration, it perhaps makes sense to put this into a low priority bucket.

@bassosimone bassosimone added effort/L Large effort priority/low Low priority labels Dec 19, 2019
@hellais hellais added the ooni/probe-engine Issues related to github.com/ooni/probe-engine label Jan 16, 2020
@bassosimone bassosimone self-assigned this Feb 17, 2020
@bassosimone
Copy link
Member Author

It seems we're not sold about implementing the rest of orchestration, and we're leaning towards decoupling orchestration for notification and orchestration for fetching targets, so this issue is less important now.

@bassosimone
Copy link
Member Author

We're not going to implement more of probe orchestration. We're going to use Countly for sending notifications to mobile users. So we can safely close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/L Large effort enhancement New feature or request ooni/probe-engine Issues related to github.com/ooni/probe-engine priority/low Low priority
Projects
No open projects
Development

No branches or pull requests

2 participants