New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Formatter adds a space after some lines #7

Open

max-sixty opened this issue Mar 17, 2022 · 1 comment

max-sixty commented Mar 17, 2022

Thanks for the excellent extension! I find it the best one available.

But currently the toml formatter will add a space after some lines — here's a preview of the diff:

diff --git a/pyproject.toml b/pyproject.toml
index d8bb503..c9ff7e2 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -19,31 +19,31 @@ pattern = 'v?(?P<base>[\d\.]+)'
 [tool.poetry.dependencies]
 python = ">=3.7, <3.10"
 
-PyYAML = "^5.3.1" 
-boto3 = "^1.20.13" 
-click = "^8.0.3" 
+PyYAML = "^5.3.1"
+boto3 = "^1.20.13"
+click = "^8.0.3"

Is this intended?

ferndot commented Jul 18, 2022

This is actually causing downstream issues for me as the trailing space is included in poetry.lock.

ferndot mentioned this issue

Python version extraction breaks if a trailing space exists moneymeets/python-poetry-buildpack#43

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment