Search sometimes shows incomplete results

[cespare]

Under some conditions, the search will not return the full 10 results even when there are more than 10 matching commits:

When this happens, if you page forward and then back, the search box will be too short (it was sized to fit < 10 elements) and you get an overflow:

[cespare]

This appears to be a bug with "only show unapproved". (That filter is applied to the first search in the above images). If I approve more commits showing on the front page, then the first page gets smaller and smaller and the trailing 2 results that aren't shown stay on the second page. If I approve all the commits on the front page, then "no results" is shown and there's no way to get to those trailing commits at all (or any indication that they might exist).

[philc]

Yep, there must be a bug in there somewhere. There's another ticket in our issue list alluding to this.

[cespare]

Related to #144.

[zdyn]

Can you still repro this? I can't repro locally on the latest production release.

[cespare]

@zdyn I'm not sure of all the repro conditions, tbh. I'll try to play around with it more and see if I can figure them out. Any chance it was inadvertently fixed by your fix to #144?

[zdyn]

I tested on an older commit and couldn't repro but then I could've been doing it wrong.

[cespare]

I can't reproduce this. I'm going to close it for now. I'll reopen with more details if I can figure out the repro conditions.

[cespare]

This happened again today with one of my commits. I'm still not 100% sure of the conditions, but it only happened with 'only show unapproved'.

I'm going to reopen as this is definitely still a bug.