Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Search sometimes shows incomplete results #201

Open
cespare opened this Issue · 8 comments

3 participants

@cespare
Collaborator

Under some conditions, the search will not return the full 10 results even when there are more than 10 matching commits:

screenshot

When this happens, if you page forward and then back, the search box will be too short (it was sized to fit < 10 elements) and you get an overflow:

screenshot

@cespare
Collaborator

This appears to be a bug with "only show unapproved". (That filter is applied to the first search in the above images). If I approve more commits showing on the front page, then the first page gets smaller and smaller and the trailing 2 results that aren't shown stay on the second page. If I approve all the commits on the front page, then "no results" is shown and there's no way to get to those trailing commits at all (or any indication that they might exist).

@philc
Collaborator

Yep, there must be a bug in there somewhere. There's another ticket in our issue list alluding to this.

@cespare
Collaborator

Related to #144.

@zdyn
Collaborator

Can you still repro this? I can't repro locally on the latest production release.

@cespare
Collaborator

@zdyn I'm not sure of all the repro conditions, tbh. I'll try to play around with it more and see if I can figure them out. Any chance it was inadvertently fixed by your fix to #144?

@zdyn
Collaborator

I tested on an older commit and couldn't repro but then I could've been doing it wrong.

@cespare
Collaborator

I can't reproduce this. I'm going to close it for now. I'll reopen with more details if I can figure out the repro conditions.

@cespare cespare closed this
@cespare
Collaborator

This happened again today with one of my commits. I'm still not 100% sure of the conditions, but it only happened with 'only show unapproved'.

I'm going to reopen as this is definitely still a bug.

@cespare cespare reopened this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.