Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maximum js call stack exceeded #318

Closed
bkad opened this issue Aug 28, 2012 · 2 comments
Closed

maximum js call stack exceeded #318

bkad opened this issue Aug 28, 2012 · 2 comments
Labels

Comments

@bkad
Copy link
Contributor

bkad commented Aug 28, 2012

http://barkeep/commits/ooyala/acf6fa4f846fdab6bd3b1ed265eb0cb6ef1ba41a

We blow the javascript call stack and renders the page interactions useless.

@dmac
Copy link
Contributor

dmac commented Aug 28, 2012

If this happens because we're attaching events to each line of large files, we might start by looking at jQuery.on, which will attach the events to ancestor nodes.

@cespare
Copy link
Contributor

cespare commented Aug 29, 2012

This is already documented in #220 (it's the first case). The fact that we've had this issue come up so many times (I think I've closed this ticket as a dup about 4 times now) indicates how important it is for us to address this quickly.

@dmacdougall that's a good point -- we should be doing that anyway, and even if that won't fix really massive diffs (which we shouldn't try to load onto the page anyway) it will be a good start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants