Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When in "only show unapproved" saved search and last commit on a page is approved, the paging buttons stop working. #392

Open
jbhat opened this issue Feb 5, 2013 · 2 comments

Comments

@jbhat
Copy link

jbhat commented Feb 5, 2013

I have a saved search (say all commits for noah), and I set it to only show unapproved commits. When code reviewing, I usually start at the end, and review/approve until at the top of the page, and then move back a page. When I have approved the last commit on a page, the "previous page" button (as well as the "next page") button do not work. I have to reload the page, and page to the (new) last page. This can be quite frustrating when there are several pages of commits to review, and paging through them can be very slow...

@philc
Copy link
Contributor

philc commented Feb 5, 2013

Yep, very frustrating, and I think it's been filed before.

As a work around, I've been opening all of the commits that I want to review first (in new tabs) so I don't run into this.

@cespare
Copy link
Contributor

cespare commented Feb 28, 2013

I can't find an issue for this. Definitely an obnoxious bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants