Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice type QS incorrectly listed as PIN instead of CN #103

Closed
JasperBeaurain opened this issue May 3, 2023 · 1 comment
Closed

Notice type QS incorrectly listed as PIN instead of CN #103

JasperBeaurain opened this issue May 3, 2023 · 1 comment
Assignees
@bertrand-lorentz
Labels
documentation Improvements or additions to documentation

Comments

@JasperBeaurain
Copy link

In table 1 n this page: https://docs.ted.europa.eu/eforms/latest/schema/schemas.html
QS (Notice subtype 15) is listed as a Prior information notice, while it is a contract notice.

The sdk itself confirms that it is indeeed a CN: https://github.com/OP-TED/eForms-SDK/blob/develop/notice-types/notice-types.json
bertrand-lorentz added a commit that referenced this issue May 3, 2023
@bertrand-lorentz
schema: Fix document type for notice subtype 15
2e24a37 
Notice subtype 15 "Notice on the existence of a qualification system"
is defined in notice-types.json as using the "CN" document type,
corresponding to the "ContractNotice" root element.
Align the documentation with this.

Fixes issue #103.
@bertrand-lorentz bertrand-lorentz self-assigned this May 3, 2023
@bertrand-lorentz bertrand-lorentz added the documentation Improvements or additions to documentation label May 3, 2023
@bertrand-lorentz
Copy link
Contributor

Thanks for your feedback.
The documentation pages have been corrected to be consistent with notice-types.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bertrand-lorentz bertrand-lorentz

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JasperBeaurain @bertrand-lorentz