Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Placement of nodeId "ND-LotTenderingProcess" in NTDs #386

Closed
sbo2718 opened this issue Mar 27, 2023 · 1 comment
Closed

Incorrect Placement of nodeId "ND-LotTenderingProcess" in NTDs #386

sbo2718 opened this issue Mar 27, 2023 · 1 comment
Labels
notice-types Related to the notice type definitions (/notice-types).

Comments

@sbo2718
Copy link

sbo2718 commented Mar 27, 2023

In 1.6.0 the group "GR-Lot-Purpose" received the nodeId "ND-LotTenderingProcess".

According to https://docs.ted.europa.eu/eforms/latest/notice-types/index.html my assumption is that all fields having this node as an ancestor should be a part of this group, but for some of the fields like BT-131(d)-Lot and BT-131(t)-Lot that is not the case.

@bertrand-lorentz
Copy link
Contributor

Thanks for your feedback.

As indicated in the documentation page:

There is no constraint on non-repeatable groups. An arbitrary number of intermediate, non-repeatable groups can be created to organize the notice fields in a more convenient way.

In this case, fields like BT-131(d)-Lot are in a different non-repeatable group than other fields that are also under the node "ND-LotTenderingProcess". But the closest repeatable parent is the same : GR-Lot.
So the notice type definition is still "aligned" with the XML structure: Both only allow one occurrence of BT-131(d)-Lot in a lot.

The association of a group to a node is relevant for the structure only for repeatable groups. We have added other associations to help relate the XML with the form shown to a user (in particular for validation messages), but they are not necessary from a structural perspective.

I'm closing this as it does not seem to be a problem in the SDK.

@bertrand-lorentz bertrand-lorentz added the notice-types Related to the notice type definitions (/notice-types). label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notice-types Related to the notice type definitions (/notice-types).
Projects
None yet
Development

No branches or pull requests

2 participants