Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON.parse not throwing StandardError #1545

Closed
catmando opened this issue Aug 3, 2016 · 1 comment
Closed

JSON.parse not throwing StandardError #1545

catmando opened this issue Aug 3, 2016 · 1 comment
Labels
bug good first issue stdlib

Comments

@catmando
Copy link
Contributor

catmando commented Aug 3, 2016

This works in IRB
JSON.parse('foo') rescue 'foo'
but not in opal 0.10
@elia
Copy link
Member

elia commented Aug 5, 2016

The solution would be to wrap the call to $parse here with a JS try/catch and throw the correct Ruby errors instead of the native ones.

@bkutil bkutil mentioned this issue Oct 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue stdlib
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elia @catmando