Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pay attention about redefinition of undefined. #25

Closed
meh opened this issue Oct 7, 2011 · 1 comment
Closed

Pay attention about redefinition of undefined. #25

meh opened this issue Oct 7, 2011 · 1 comment

Comments

@meh
Copy link
Member

meh commented Oct 7, 2011

undefined can be set to something else, as in, undefined is a valid variable name, we should find a way to avoid redefinition of undefined.

The best way to go with this is to add var undefined at the beginning of each function, or find a better way to avoid cluttering up everything.

@adambeynon
Copy link
Contributor

Well we can be quite liberal with var undefined as minifying the result will remove any that aren't used, so this seems a good idea- we can't trust what users do in their code.

@meh meh closed this as completed Dec 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants