New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Dark Mode + File counter #13
Conversation
Also, i wasn't sure whether to commit the generated |
Thanks again for the awesome project. Does what it says on the box. No setup required; just plain and simple. Some ideas I think could make it even better:
|
Hey @shalvah , thanks for the PR! I have a few thoughts that hopefully make sense.
All in all, the intetion and code are great, but I think this PR lacks some UX and design flair. I have "Dark Mode" on my todo list and will be working on it later with one of my designer friends. But in the meantime, you can publish your own fork on Packagist and require it in your project so you have Dark Mode right now 😄 |
Well, that's disappointing. Spent my entire morning on this. But it's your call.
Why? I find it extremely useful to know how many log files I have. Unless you mean the implementation. But I understand about separate PRs.
I agree, but that settings dropdown only shows up when you select a log file, and I didn't want to unilaterally change that.
Like I said, I'm not a front-end person, so I don't know all the details. (I do know about minification, but it didn't occur to me.)🥲 |
@@ -12,8 +12,13 @@ | |||
<style>{!! file_get_contents($cssPath) !!}</style> | |||
@endisset | |||
@livewireStyles | |||
@if(session('log-viewer:theme', 'system') == 'system') | |||
<script> | |||
document.documentElement.classList.add('dark') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I just realised there's a bug here. I forgot to add window.matchMedia("prefers-color-scheme...")
thing. 🤣
Apologies if I missed anything; I'm not a frontend guy. Also haven't done much testing in other browsers/OSes.
Screens:
Home