-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering by log type and then changing log causes fatal error #39
Comments
Hey @dkmonaghan , thanks for reporting this! The line this fails at means it's not finding the timestamp for this particular log entry. This tells me there might be something in the second log file (the one you're switching to later) that's not properly understood by the log viewer. Could you please share the full log file (as an attachment, not a quote here) that you're switching to in your example? Thanks! 🙌 |
Hi @arukompas - thanks for the quick reply! I've just spent some time removing lines from my test log file to see where it fails, and it seems like there's no line specifically that's causing it to fail. I'm actually even more baffled than I was before, and I think the de-selecting of "NOTICE" was actually a red herring. The behaviour happens regardless of whether or not I have any filtering of event types enabled. I've created a log file called
I'm pretty stumped by this. I have log files that are multiple megabytes large that render fine, yet the above fails to render. The request that actually returns the HTTP 500 is a call to If it helps, here is the request payload to that Livewire endpoint. Additionally, while experimenting, I discovered that the viewer fails with a fatal error if no logs at all are found in the directory, rather than failing gracefully. It'd be nice if it didn't do this! |
hey @dkmonaghan , ok, so there's 2 bugs now! :D 1. The exception when viewing test.logI'm still finding it difficult to replicate 😅 Maybe the issue is with a different PHP version or a different OS, which behaves slightly differently or has a different REGEX behaviour... Here's the latest (v1.2.1) log viewer that handles this test.log file with just a single line, just fine: I've made a small bugfix to validate the last log entry. Could you please upgrade to the latest ( If it still fails, could you please let me know:
This might help me debug the issue if I can mimick the exact environment. 2. Failure when no log files are foundI was testing this and found that the exception only occurs when the file from the query param (e.g. |
Hi @arukompas
Log Viewer Version = 1.2.3
|
Hey @dkmonaghan , please try the latest version as there have been some changes to the regular expressions used to match the logs. Thanks! |
Hello - this package looks lovely, and I'm excited to use it in my app!
I've found a bug which I seem to be able to reproduce reliably.
This then causes a fatal error, as demonstrated below.
Let me know if you require any more info. Cheers!
The text was updated successfully, but these errors were encountered: