Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mps): Input validation checks in APFProcessor for max size #597

Merged
merged 1 commit into from Apr 22, 2022

Conversation

tim-shockley
Copy link
Contributor

@tim-shockley tim-shockley commented Apr 22, 2022

AB#6610

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #597 (807a7f7) into main (18aa98d) will increase coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 807a7f7 differs from pull request most recent head b5c0360. Consider uploading reports for the commit b5c0360 to get more accurate results

@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   91.47%   91.56%   +0.09%     
==========================================
  Files          68       68              
  Lines        2990     3000      +10     
  Branches      472      482      +10     
==========================================
+ Hits         2735     2747      +12     
+ Misses        255      253       -2     
Impacted Files Coverage Δ
src/amt/APFProcessor.ts 99.72% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18aa98d...b5c0360. Read the comment docs.

@tim-shockley tim-shockley merged commit 82e3efd into main Apr 22, 2022
@tim-shockley tim-shockley deleted the AB-6610 branch April 22, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants