Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Only count contributors with active public items for type count #1002

Merged
merged 1 commit into from Mar 23, 2020

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Mar 23, 2020

Overview

We recently updated the contributors filter dropdown to only contain
contributors that have active, public list items. In this commit we fix the
contributor type counts by applying the same filter criteria before counting.

Connects #1001

Testing Instructions

  • Run ./scripts/resetdb
  • Browse http://localhost:6543/, open the contributor types dropdown and verify that "Auditor" has a count of "[1]"
  • Register a new account with type "Auditor," confirm it, and log in.
  • Browse http://localhost:6543/, open the contributor types dropdown and verify that "Auditor" still has a count of "[1]"
  • Browse http://localhost:6543/contribute and upload one-bad-one-good.csv.zip
  • Process the list through the first 2 steps
    • ./scripts/manage batch_process --list-id 16 --action parse
    • ./scripts/manage batch_process --list-id 16 --action geocode
  • Browse http://localhost:6543/, open the contributor types dropdown and verify that "Auditor" still has a count of "[1]"
  • Process the list through the final step
    • ./scripts/manage batch_process --list-id 16 --action match
  • Browse http://localhost:6543/, open the contributor types dropdown and verify that "Auditor" now has a count of "[2]"

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@TaiWilkin
Copy link
Contributor

Looks good, and worked as expected

@jwalgran
Copy link
Contributor Author

Thanks for the review.

We recently updated the contributors filter dropdown to only contain
contributors that have active, public list items. In this commit we fix the
contributor type counts by applying the same filter criteria before counting.
@jwalgran jwalgran force-pushed the feature/jcw/fix-contrib-type-counts branch from 9a51907 to 4203417 Compare March 23, 2020 18:51
@jwalgran jwalgran merged commit fa8063c into develop Mar 23, 2020
@jwalgran jwalgran deleted the feature/jcw/fix-contrib-type-counts branch March 23, 2020 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants