Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add country first appearance report #1024

Merged
merged 1 commit into from Jun 17, 2020

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Jun 3, 2020

Overview

We have an existing report that counts the number of countries added each month.
This report attempts to answer the follow up question "which countries?"

Demo

Screen Shot 2020-06-03 at 9 48 31 AM

Screen Shot 2020-06-03 at 9 48 22 AM

Testing Instructions

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

We have an existing report that counts the number of countries added each month.
This report attempts to answer the follow up question "which countries?"
Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks great!

@rajadain rajadain assigned jwalgran and unassigned rajadain Jun 3, 2020
@jwalgran
Copy link
Contributor Author

Thanks for the review.

@jwalgran jwalgran merged commit ebd0c21 into develop Jun 17, 2020
@jwalgran jwalgran deleted the feature/jcw/add-country-first-appearance-report branch June 17, 2020 15:12
@jwalgran
Copy link
Contributor Author

Forgot the changelog. Will add a followup commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants