This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Use popovers for help text and match PPE checkbox style to contributor overlap #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Tooltip could not be easily closed on a phone-size screen. The new Popover-based implementation is based on the Popover documentation https://v3.material-ui.com/utils/popover/ We reduced the font size in the popover so it would fit comfortable in a 240x320 screen.
We add an info button with explanatory text for the PPE checkbox and we restyle and relabel the checkbox to match the contributor overlap checkbox.
mmcfarland
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
I was only able to use the dev tools simulators to test this, and for screens larger than the iPhone 5 it fit nicely. I'm not sure if my attempts to use BrowserStack and ngrok for my local device failed due to the way I am using port forwarding to access a remote workstation on my development laptop, or if it has to do with the project setup.
|
Thanks for the review. |
|
@designmatty Thanks for suggesting switching the OAR "more information" feature from Tooltips to Popovers. It worked out well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Replace the Tooltip on the search sidebar with a Popover to avoid problems on mobile, add a Popover for PPE help, and match the PPE checkbox style to contributor overlap checkbox style.
Connects #1047
Demo
Testing Instructions
Checklist
fixup!commits have been squashed