Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add alternate country names #1064

Merged
merged 1 commit into from Jul 30, 2020
Merged

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Jul 30, 2020

Overview

These missing country names were encountered while processing lists in production.

Connects #1063

Testing Instructions

These instructions assume you have run ./scripts/resetdb

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@rajadain rajadain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 tested!

❯ vkj manage batch_process -l 16 -a parse

parse: 809 successes
parse: 14 failures
❯ vkj manage batch_process -l 17 -a parse

parse: 823 successes

@rajadain rajadain assigned jwalgran and unassigned rajadain Jul 30, 2020
These were encountered while processing lists in production.
@jwalgran jwalgran force-pushed the feature/jcw/add-country-names branch from b4afd26 to 3ce5e7b Compare July 30, 2020 14:38
@jwalgran
Copy link
Contributor Author

Thanks for the review.

@jwalgran jwalgran merged commit 7dcb884 into develop Jul 30, 2020
@jwalgran jwalgran deleted the feature/jcw/add-country-names branch July 30, 2020 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants