Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Allow setting NOTIFICATION_EMAIL_TO from a deployment var #1203

Merged
merged 1 commit into from Jan 8, 2021

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Jan 7, 2021

Overview

The NOTIFICATION_EMAIL_TO setting is the address to which notifications about API usage limits are sent. We add the ability to set the value via a terraform variable during provisioning.

Connects #1202

Demo

The ECS task properties after deploying to staging

Screen Shot 2021-01-07 at 3 37 34 PM

Testing Instructions

  • Visually inspect the code and verify that task in the staging cluster have the environment variable set,

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

@jwalgran jwalgran marked this pull request as ready for review January 7, 2021 22:41
Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the assist in getting to the containers! This works well, and I can see the correct variable in ECS.

@TaiWilkin TaiWilkin assigned jwalgran and unassigned TaiWilkin Jan 8, 2021
@jwalgran
Copy link
Contributor Author

jwalgran commented Jan 8, 2021

Thanks for the review.

The NOTIFICATION_EMAIL_TO setting is the address to which notifications about
API usage limits are sent. We add the ability to set the value via a terraform
variable during provisioning.
@jwalgran jwalgran force-pushed the feature/jcw/notification-email-to-var branch from 165fcea to b643d45 Compare January 8, 2021 17:17
@jwalgran jwalgran merged commit 4090799 into develop Jan 8, 2021
@jwalgran jwalgran deleted the feature/jcw/notification-email-to-var branch January 8, 2021 20:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants