This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Add page to manage cookie preferences #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaiWilkin
force-pushed
the
tw/add-cookie-management
branch
from
6fbc9d5
to
7ebdc53
Compare
|
Looking at this now. |
jwalgran
approved these changes
Jan 21, 2021
Comment on lines
60
to
72
| <div> | ||
| The Open Apparel Registry uses cookies to collect and analyze | ||
| site performance and usage. By clicking the Accept button, you | ||
| agree to allow us to place cookies and share information with | ||
| Google Analytics. For more information, please visit our{' '} | ||
| <a | ||
| href="https://info.openapparel.org/tos/" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| > | ||
| Terms and Conditions of Use and Privacy Policy. | ||
| </a> | ||
| </div> |
There was a problem hiding this comment.
Consider extracting this tex into a component that can be used both here and in GDPRNotification.jsx. If we need to update this language in the future it will eliminate the possibility of accidentally updating it in one place and not another.
There was a problem hiding this comment.
Good call! Thank you for the review!
Gives the user the option to access a cookies preferences page where they can choose to change the opt in or out preference that they set when first visiting OAR.
TaiWilkin
force-pushed
the
tw/add-cookie-management
branch
from
7ebdc53
to
51a8f07
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Gives the user the option to access a cookies preferences page where
they can choose to change the opt in or out preference that they set
when first visiting OAR.
Connects #1191
Demo
Testing Instructions
./scripts/serverChecklist
fixup!commits have been squashed