This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Rename Taiwan #1234
Merged
Rename Taiwan #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwalgran
approved these changes
Feb 8, 2021
China's claim on Taiwan is not recognised by US nor international law. We have been advised to switch Taiwan's listing in the OAR to reflect this.
TaiWilkin
force-pushed
the
tw/rename-taiwan
branch
from
b1bd725
to
b8484ea
Compare
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
China's claim on Taiwan is not recognised by US nor international law.
We have been advised to switch Taiwan's listing in the OAR to reflect
this.
Connects #1226
Demo
Testing Instructions
./scripts/serverChecklist
fixup!commits have been squashed