Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Update Reject Button Text #1244

Merged
merged 1 commit into from Feb 17, 2021
Merged

Update Reject Button Text #1244

merged 1 commit into from Feb 17, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Feb 16, 2021

Overview

Dashboard activity report reject dialog has a confirm button. The
button has been updated to display the text, "Reject".

Connects #1241

Demo

Screen Shot 2021-02-16 at 12 09 06 PM

Testing Instructions

  • Run ./scripts/server
  • Submit a closure activity report
  • Log in as an admin and browse activity reports
  • Click reject on the pending activity report.
    • The buttons should say 'cancel' and 'reject'

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not pull this down and test it, but it looks good.

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Feb 16, 2021
Dashboard activity report reject dialog has a confirm button. The
button has been updated to display the text, "Reject".
@TaiWilkin TaiWilkin merged commit c3e3855 into develop Feb 17, 2021
@TaiWilkin TaiWilkin deleted the tw/update-reject-text branch February 17, 2021 15:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants