Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add verbose debug logging to API block checking #1274

Merged
merged 1 commit into from Mar 8, 2021

Conversation

jwalgran
Copy link
Contributor

@jwalgran jwalgran commented Mar 8, 2021

Add detailed debug logging statement so we can get more information about how API blocks are being handled in production.

Connects https://github.com/open-apparel-registry/open-apparel-registry-clients/issues/23

Notes

⚠️ This is targeted at the hotfix/2.39.2 branch

Demo

Deployed to staging showing log results in ECS

Screen Shot 2021-03-08 at 1 33 46 PM

Testing Instructions

  • Make API requests with a token and verify that the additional debug statements appear in the log

Checklist

  • The Jenkinsfile edit in 7acc349 has been dropped
  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@TaiWilkin TaiWilkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TaiWilkin TaiWilkin assigned jwalgran and unassigned TaiWilkin Mar 8, 2021
@jwalgran jwalgran force-pushed the feature/jcw/add-api-block-logging branch from f127131 to 68eec45 Compare March 8, 2021 21:39
We want to get more information about how API blocks are being handled in
production.
@jwalgran jwalgran force-pushed the feature/jcw/add-api-block-logging branch from 68eec45 to 81466d3 Compare March 8, 2021 21:45
@jwalgran
Copy link
Contributor Author

jwalgran commented Mar 8, 2021

Thanks for the review.

@jwalgran jwalgran merged commit fb9a0cb into hotfix/2.39.2 Mar 8, 2021
@jwalgran jwalgran deleted the feature/jcw/add-api-block-logging branch March 8, 2021 21:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants