Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Provide Constant Access to GDPR #1279

Merged
merged 1 commit into from Mar 12, 2021
Merged

Provide Constant Access to GDPR #1279

merged 1 commit into from Mar 12, 2021

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Mar 11, 2021

Overview

Allows users to click a link in the footer (on web) or in the dropdown
menu (on mobile) to open the GDPR notification, at which point they
can choose to accept or reject cookies, clearing their previous
selection.

Connects #1261

Demo

Screen Shot 2021-03-11 at 3 02 22 PM

Screen Shot 2021-03-11 at 3 02 10 PM

Testing Instructions

  • Run ./scripts/server and navigate to localhost:6543/
  • Clear your local storage and refresh the page
    • You should see the GDPR notification
  • Select Accept or Reject
    • Your preference should be updated in local storage appropriately
  • Click on 'Cookie Preferences' in the footer
    • You should see the GDPR notification
  • Select Accept or Reject
    • Your preference should be updated in local storage appropriately
  • Make the viewport narrow to simulate mobile and click the Menu button
    • You should see a 'Cookie Preferences' button
  • Click on the 'Cookie Preferences' menu item
    • You should see the GDPR notification
  • Select Accept or Reject
    • Your preference should be updated in local storage appropriately

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@jwalgran jwalgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly. Nice, unobtrusive design.

@jwalgran jwalgran assigned TaiWilkin and unassigned jwalgran Mar 11, 2021
Allows users to click a link in the footer (on web) or in the dropdown
menu (on mobile) to open the GDPR notification, at which point they
can choose to accept or reject cookies, clearing their previous
selection.
@TaiWilkin TaiWilkin merged commit 5857685 into develop Mar 12, 2021
@TaiWilkin TaiWilkin deleted the tw/add-gdpr-opt-out branch March 12, 2021 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants